Closed
Conversation
739b7b0 to
6dd6041
Compare
Member
Author
|
Well, I think we can start from node 12 :) |
ctcpip
requested changes
Jul 8, 2025
blakeembrey
requested changes
Jul 8, 2025
Member
blakeembrey
left a comment
There was a problem hiding this comment.
Ditto to @ctcpip's comments. I'm not against bumping the minimum node version, but I'd prefer to do it when we have major changes to the API.
I'm also sympathetic to it potentially being a maintenance burden for old versions but that's not what I've seen so far.
Member
Author
|
If you don’t want to make the change to a major Node version yet, I’m perfectly fine with that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll start from version 10, since we want to support HTTP2 directly in the tests (#16)