test: remove duplicate test for setHeader availability#43
Open
Ayoub-Mabrouk wants to merge 1 commit intojshttp:masterfrom
Open
test: remove duplicate test for setHeader availability#43Ayoub-Mabrouk wants to merge 1 commit intojshttp:masterfrom
Ayoub-Mabrouk wants to merge 1 commit intojshttp:masterfrom
Conversation
Remove duplicate test "should be available in listener" in setHeader describe block that was identical to the existing "should fire after setHeader" test. Both tests used the same echoListener and verified the same functionality. - Removed: "should be available in listener" (setHeader describe block) - Kept: "should fire after setHeader" (main describe block) This reduces test count from 24 to 23 while maintaining full coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove duplicate test "should be available in listener" in setHeader
describe block that was identical to the existing "should fire after
setHeader" test. Both tests used the same echoListener and verified
the same functionality.
This reduces test count from 24 to 23 while maintaining full coverage.