Adds support for HTAB as well as SP as whitespace separators in content-type headers#53
Open
rg2011 wants to merge 1 commit intojshttp:masterfrom
Open
Adds support for HTAB as well as SP as whitespace separators in content-type headers#53rg2011 wants to merge 1 commit intojshttp:masterfrom
HTAB as well as SP as whitespace separators in content-type headers#53rg2011 wants to merge 1 commit intojshttp:masterfrom
Conversation
68 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #52. Notes:
The fix applies to both
typeisandtypeis.is, instead of justtypeis.This is because
typeis.iscan receive a req-like or res-like object (this behaviour is undocumented but tested). I wanted to avoid situations wheretypeis(req, ...)would work buttypeis.is(req, ...)would not.The fix breaks backward compatibility in that, previously,
typeiswould fail if the content-type parameters were not properly formatted. But, after this PR, it will just ignore them.i.e. previously, this would return
false:typeis.is('application/json; charset:utf-8', 'json') // Notice the ":" instead of "=" in charsetBut after this PR, it will return
"json".This behaviour was documented (...If the
Content-Typeheader is invalid...):type-is/README.md
Lines 35 to 38 in 7d19b7a
But it was not tested in the case of invalid parameters. I am not sure of the best way forward:
After this PR,
media-typerdependency could be upgraded to 1.1.0.