Icon overhaul and added "Commando" support weapon.

[lbrunkho]

This is a pretty big PR that implements an overhaul of the icons to vector formats and other improvements.

Icon Overhaul

• Cleaner look IMO.
• Easier to recognize.
• README has been updated with attributions section to link to the upstream icon repo.
• A couple Icons didn't have direct replacements (HD Logo, Step forward / backward, and Stratagem Hero) and haven't been updated.
• I didn't add the IlluminationFlare icon as it isn't in the game yet.
• SVG Icons have inherent transparency. You have have backgrounds if you want!

Other Improvements

• Removed labels as I believe the better icons make the labels less needed.
• Added Commando call-in weapon.
• Improved README formatting.

[jslay88]

First, I greatly appreciate your interest and efforts to contribute to the project, and I welcome all suggestions and ideas.

However, I have a few reservations for this PR.

• Labels are missing, and for some, that is a deal breaker. If we are going to remove labels, it should be more of a global choice/option. There are ideas around a plugin settings page, but I have tried to start implementing some form of a global plugin settings page on this branch here.
• Transparent backgrounds should also be a global and per-button toggle option.
• The SVG Icons seem to be under saturated in color compared to in-game colors. If you take a screenshot of in-game stratagems and compare, it is quite different (especially the red).
• Corner/edge effects seem to be inconsistent? Some have diamonds in the corner where as others have nothing.
• I am also curious about leveraging the "icon pack" feature of StreamController, and having multiple icon packs of various styles. Maybe this is a good kickoff point to start that.

[lbrunkho]

Totally understand your reservations. I kinda knew that I was making changes that are a right-hand turn so to speak.

I would have been VERY surprised if this was just merged in. :p

I like the idea of a global label toggle! I don't really have the coding experience to implement that feature. I'll make a new branch in my fork and start adding labels back. I might try to use abbreviations if a single word will run off the screen (example would be "OPS" for "orbital precision strike").

I'll also work on grabbing a couple screenshots of the icons in-game and see if I can update the color pallets to better match what's in the game.

Looks like all "general stratagems" have the corner diamonds. Might be a nice visual indicator to help separate these buttons but that can be easily removed while I'm updating the color pallets.

Let me dig into the icon pack idea a bit more (example https://github.com/StreamController/Material-Icons). Perhaps there is a way to list dependencies for the main plugin to require certain icon packs?

You can close this PR and I'll see what I can get done.

[jslay88]

No need to close the PR. We can leverage it for a point of discussions. I’m willing to bet if you dig into my other branch you could probably figure out a way to do this global toggle. Just takes a minute to play with the code to understand what’s happening.

…

On Fri, Jul 19, 2024 at 12:04 lbrunkho ***@***.***> wrote: Totally understand your reservations. I kinda knew that I was making changes that are a right-hand turn so to speak. I would have been VERY surprised if this was just merged in. :p I like the idea of a global label toggle! I don't really have the coding experience to implement that feature. I'll make a new branch in my fork and start adding labels back. I might try to use abbreviations if a single word will run off the screen (example would be "OPS" for "orbital precision strike"). I'll also work on grabbing a couple screenshots of the icons in-game and see if I can update the color pallets to better match what's in the game. Looks like all "general stratagems" have the corner diamonds. Might be a nice visual indicator to help separate these buttons but that can be easily removed while I'm updating the color pallets. Let me dig into the icon pack idea a bit more (example https://github.com/StreamController/Material-Icons). Perhaps there is a way to list dependencies for the main plugin to require certain icon packs? You can close this PR and I'll see what I can get done. — Reply to this email directly, view it on GitHub <#11 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABO7UUNUBB3IWELBZ45QEO3ZNFIMJAVCNFSM6AAAAABLDDO2PSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZZHAZDKNJWGU> . You are receiving this because you commented.Message ID: ***@***.***>

[jslay88]

#14 adds the ability to disable labels for the plugin, as well as the ability to map your own colors, from a developers perspective. ergo, cloning into your data dir and regenerating the icons using the update script.

For the icons, the script pulls the SVGs from a maintained repo, strips any borders/decorations (the triangle corners for instance), figures out what color the SVG does use, scales it down to 70% of the original, then generates a PNG using the remapped colors (more saturated red, green, yellow), with a custom border, all dynamically.

Will be closing this at this point.