Skip to content

Bring back Visualized tab.#917

Merged
BigBlueHat merged 6 commits intomainfrom
switch-to-esbuild
Apr 2, 2026
Merged

Bring back Visualized tab.#917
BigBlueHat merged 6 commits intomainfrom
switch-to-esbuild

Conversation

@BigBlueHat
Copy link
Copy Markdown
Member

@BigBlueHat BigBlueHat commented Feb 23, 2026

Brought back the "Visualized" tab by resurrecting jsonld-vis (forked into this org if anyone wants to help 😁).

So much simpler. So much faster.
@BigBlueHat BigBlueHat requested a review from pchampin February 23, 2026 19:47
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Feb 23, 2026

Deploying json-ld-org with  Cloudflare Pages  Cloudflare Pages

Latest commit: 01a15b2
Status: ✅  Deploy successful!
Preview URL: https://426a3f22.json-ld-org.pages.dev
Branch Preview URL: https://switch-to-esbuild.json-ld-org.pages.dev

View logs

@davidlehn
Copy link
Copy Markdown
Member

  • Are the non-esbuild commits supposed to be here?
  • Isn't rolldown the new bling?

Comment thread README.md
Comment thread README.md
@BigBlueHat BigBlueHat changed the title Switch to esbuild from rollup. Bring back Visualized tab. Mar 27, 2026
Too many calls to setOutputTab from too many places.
@BigBlueHat
Copy link
Copy Markdown
Member Author

  • Isn't rolldown the new bling?

Maybe. Not sure it's worth the lift to do it again, though.

@BigBlueHat BigBlueHat requested a review from wes-smith March 27, 2026 20:21
Copy link
Copy Markdown
Contributor

@pchampin pchampin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why but I was unable to test this with npm run pages (gave 404 errors everywhere) for a while, but now it is working!

Looking good from an end-user's perspective. I can't really talk for the JS intricacies of the esbuild vs. rollup vs. rolldown discussion.

@BigBlueHat
Copy link
Copy Markdown
Member Author

I don't know why but I was unable to test this with npm run pages (gave 404 errors everywhere) for a while, but now it is working!

Could you file an issue for that and what you're seeing in the CLI? Thanks!

@pchampin
Copy link
Copy Markdown
Contributor

pchampin commented Apr 2, 2026

I'm happy to open an issue, but as the issue has magically disappeared, I'm not sure what I can contribute. I don't remember anything in the CLI different then from what I see now :-/

Several high level security issues were present. Upgrades
fixed that (for now...).
@BigBlueHat BigBlueHat merged commit 583d97f into main Apr 2, 2026
1 check passed
@BigBlueHat BigBlueHat deleted the switch-to-esbuild branch April 2, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants