Skip to content

Conversation

@Siddhartha20242
Copy link

@Siddhartha20242 Siddhartha20242 commented Dec 28, 2025

What kind of change does this PR introduce?

  • Bugfix
  • UI Improvement

Issue Number:
Closes #2042

Screenshots/videos:
https://github.com/user-attachments/assets/9bb29c49-beb4-4ad0-94f1-9735fdd55760

If relevant, did you update the documentation?
N/A

Summary:
Currently, the feedback buttons (Like/Dislike) in the footer only support a "click-to-open" state. If a user clicks a button accidentally, they cannot click the same button again to toggle the form closed. This PR introduces a toggle mechanism using a selectedvote state, allowing the user to dismiss the feedback form by clicking the active button again.

Does this PR introduce a breaking change?
No.

Checklist

  • Read, understood, and followed the contributing guidelines.

@github-actions
Copy link

Hi @Siddhartha20242! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@github-actions
Copy link

github-actions bot commented Dec 28, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview cca22e8

@codecov
Copy link

codecov bot commented Dec 28, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.53%. Comparing base (aa0a2ff) to head (e1296f7).

Files with missing lines Patch % Lines
components/DocsHelp.tsx 75.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main    #2043      +/-   ##
===========================================
- Coverage   100.00%   99.53%   -0.47%     
===========================================
  Files           30       30              
  Lines          633      644      +11     
  Branches       196      199       +3     
===========================================
+ Hits           633      641       +8     
- Misses           0        3       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Utkarsh-123github
Copy link
Member

Hi @Siddhartha20242 , thank you for the effort. Before raising a PR, the issue needs to pass triage. We require contributors to wait for assignment before raising a PR.
Also, the changes (including updates to package-lock.json and yarn.lock) are not related to this issue, and the PR is failing checks.
Please update your PR with the requested changes and make sure that your PR passes all the checks.
Thank you🙌🏻

Copy link
Member

@Utkarsh-123github Utkarsh-123github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unwanted changes in package-lock.json and yarn.lock.
Also please make sure that your PR passes all the checks.
Thank you!

@github-project-automation github-project-automation bot moved this from Ready to review to Changes requested in PR - Triage Group Dec 29, 2025
@github-actions
Copy link

Hi @Siddhartha20242! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@github-actions
Copy link

Hi @Siddhartha20242! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

3 similar comments
@github-actions
Copy link

Hi @Siddhartha20242! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@github-actions
Copy link

Hi @Siddhartha20242! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@github-actions
Copy link

Hi @Siddhartha20242! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@Siddhartha20242
Copy link
Author

Hi @Utkarsh-123github , I have fixed the PR description and reverted the accidental lockfile changes. So sorry for that. As I am a new contributor. Also, sorry for raising pr without getting assigned. As of now, only the relevant code for the toggle fix is now included. I see that Codecov is at 75% because the existing tests dont cover the double click toggle logic. Would you like me to add a unit test for this, or can we proceed with the manual verification provided in the video? Thank you so much for the guidance.

@Utkarsh-123github
Copy link
Member

Yes please fix the tests part as well.

@Siddhartha20242
Copy link
Author

Hi @Utkarsh-123github , I've updated the PR with the requested changes, but I'm hitting a race condition in the DocsHelp toggle test on the CI environment. The test fails because the second click happens before React finishes the first state update. I can fix this locally by adding a small wait or check, but the linter blocks cy.wait() and other assertions seem flaky in the CI pipeline. Do you have a preferred way to handle these toggle race conditions in this repo? I want to make sure I implement it according to your standards. I am worried what to do. I am seeing stack overflow, claude all those from past 4 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Changes requested

Development

Successfully merging this pull request may close these issues.

🐛 Bug: Clicking the Feedback "Like Button" Should Toggle if i click twice.

2 participants