fix: replace deprecated String.Prototype.substr with slice #2050
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
Summary
This PR replaces usages of the deprecated
String.prototype.substrAPI with standard and well-supported alternatives (sliceorsubstring) in the affected areas.The deprecated usage was causing ESLint/editor warnings. The changes preserve existing behavior and logic while aligning with modern JavaScript best practices.
Note on failing test
There is a pre-existing test failure in
JsonEditor.cy.tsxfor the router navigation test(should navigate correctly to each type-keyword reference page when clicked on type-keyword).This failure exists on the base branch and is unrelated to this change.
It was verified by stashing these changes and running the tests on the base branch, where the failure still occurs.
Does this PR introduce a breaking change?
Checklist