Skip to content

Conversation

@ieedan
Copy link
Collaborator

@ieedan ieedan commented Nov 29, 2025

Add support for multiline environment variables in parseEnvVariables to correctly handle values spanning multiple lines using backslash continuation.


Open in Cursor Open in Web

Co-authored-by: aidanbleser35 <aidanbleser35@gmail.com>
@cursor
Copy link

cursor bot commented Nov 29, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@changeset-bot
Copy link

changeset-bot bot commented Nov 29, 2025

⚠️ No Changeset found

Latest commit: f685d6d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
jsrepo.dev Ready Ready Preview Comment Nov 29, 2025 1:16pm

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 29, 2025

Open in StackBlitz

jsrepo

pnpm add https://pkg.pr.new/jsrepojs/jsrepo@706

@jsrepo/mcp

pnpm add https://pkg.pr.new/jsrepojs/jsrepo/@jsrepo/mcp@706

@jsrepo/migrate

pnpm add https://pkg.pr.new/jsrepojs/jsrepo/@jsrepo/migrate@706

@jsrepo/transform-biome

pnpm add https://pkg.pr.new/jsrepojs/jsrepo/@jsrepo/transform-biome@706

@jsrepo/transform-javascript

pnpm add https://pkg.pr.new/jsrepojs/jsrepo/@jsrepo/transform-javascript@706

@jsrepo/transform-prettier

pnpm add https://pkg.pr.new/jsrepojs/jsrepo/@jsrepo/transform-prettier@706

commit: f685d6d

@ieedan
Copy link
Collaborator Author

ieedan commented Nov 29, 2025

@cursoragent CI is failing fix it

@cursor
Copy link

cursor bot commented Nov 29, 2025

Fixed the CI failure. TypeScript strict mode flagged lines[i] as possibly undefined. Added a guard at the start of the loop to ensure line is defined before use.

Fix applied:

  • Added if (line === undefined) continue; check after accessing lines[i]
  • This ensures TypeScript knows line is defined for all subsequent uses in the loop

Verification:

  • All tests still pass (13/13)
  • TypeScript type checking passes for the jsrepo package
  • No linter errors

The CI should now pass. The guard clause satisfies TypeScript's strict null checking while preserving the existing behavior, since lines[i] should never be undefined when iterating within bounds.


Open in Cursor Open in Web

Learn more about Cursor Agents

Co-authored-by: aidanbleser35 <aidanbleser35@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants