Added Padrino support by default

[Who828]

Hey,

I just added a ENV variable and a default preload path to make it work with Padrino out of the box.

Thank you making this gem, It was so simple to port it :)

[kirs]

Are you sure that we need duplication here?

[Who828]

Well I wanted to add the support out of box, instead of using --preload to point to "config/boot.rb" manually.

If you want to be more verbose, I can create a method which says "padrino_app?" then use this or use the Rails default path.

My only aim is to make is simple for people who are new to this, that's all.

[kirs]

I mean that we add config/boot.rb to :preload by default and then add it one more time for padrino.

[Who828]

Ah, I am sorry.

I meant the default to be "config/application.rb". Let me revert it back to orignal line.

[kirs]

Thanks! Could you also add a changelog entry and mention the Padrino support in README?

[Who828]

I changed the README, changelog and the version. (did you want me to change the version?)
Let me know if there anything more to be done.

Regards

[kirs]

Thanks! Could you also revert the lib/spin/version.rb?

[Who828]

Done!

[kirs]

It looks like we set ENV['PADRINO_ENV'] here and then check if it's set in lib/spin/cli.rb. Are you sure that's exactly what we need?

[Who828]

I am really sorry for these types of mistakes. We can't really use ENV to determine its a Padrino app (Like I originally thought). I didn't catch this bug because I was only testing it out on a Padrino app :/

Since Spin's philosophy is to run outside of your current app, I think its best to add as an option like (--padrino) and based on that I can add these configs.

Please share your thoughts on this

[Who828]

We can also check if config/application.rb is there or not (Padrino doesn't have this file) and based on that determine if app is Padrino or Rails.

[kirs]

I don't think it's the best strategy to define "if there is no config/application.rb, then app is Padrino-based".
Is there any Padrino-specific file?

[Who828]

I checked and I couldn't find any padrino specific file.
We can also check the Gemfile (see if it has Padrino or not) but that might increase the complexity and it might not always be correct.

For example there might be a mountable gem, which has dependency on Padrino and the core app is Rails or vice versa. (though if its a dependency then it won't appear in the Gemfile, it will be in the Gemfile.lock)

I am leaning more towards just giving an option to the user (--padrino), so we don't have to break our heads to determine if its Padrino app or not.

[parasnarang]

Maybe you can use if defined?(Padrino)