Contribute DefaultLocaleExtension and DefaultTimeZoneExtension

[Bukama]

JUnit Pioneer is happy to contribute its DefaultLocaleExtension and DefaultTimeZoneExtension to JUnit Jupiter.

closes #4727

---

I hereby agree to the terms of the JUnit Contributor License Agreement.

---

Definition of Done

• There are no TODOs left in the code
• Method preconditions are checked and documented in the method's Javadoc
• Coding conventions (e.g. for logging) have been followed
• Change is covered by automated tests including corner cases, errors, and exception handling
• Public API has Javadoc and @API annotations
• Change is documented in the User Guide and Release Notes

[marcphilipp]

Thanks for this initial push! 👍

How to use JUnit's internal testkit

We just use EngineTestKit directly, without the abstraction that Pioneer has. I commented on one such test.

Why checkstyle fails just right after spotless:apply goal was run

Checkstyle can fail even though Spotless formatted the code. Spotless is purely about formatting, while we use Checkstyle for some more semantic checks.

That ArchUnit rules are in place

What did you want to check for?

[Bukama]

Thank you for your feedback, I think (hope) I applied all of it correctly. I find the testkit methods very confusing and verbose, but I guess that's a thing how used you are to them.

What did you want to check for?
Nothing, I saw that I have violations against ArchUnit's rules, but was too tired to check which I violate (turned out it was the missing @API annotations.

In general I'm done with most parts, I now have to figure out which are the correct findAnnotation methods in JUpiter to match those of Pioneer. Especially those with nested and class level ones.

[Bukama]

To keep you up to date:
Putting the classes in the api.util packages results in a circular dependency of api.extension due the TimeoutUtil class in the same package. For testing purpose I moved all of them to a dummy package (will split and rename it later) to make progress on getting the build green. I then spent some time on the module-info, but also got this now, but now test that check the module-info break. But it's far too late today. Will continue tomorrow or Saturday.

[marcphilipp]

Putting the classes in the api.util packages results in a circular dependency of api.extension due the TimeoutUtil class in the same package.

Hmm, I hadn't thought of that. We should probably move TimeoutUtil to a separate package. Let's go with org.junit.jupiter.api.timeout for now, ok?

[marcphilipp]

Hmm, I hadn't thought of that. We should probably move TimeoutUtil to a separate package. Let's go with org.junit.jupiter.api.timeout for now, ok?

Actually, I've just done this on main so it should suffice for you to rebase this PR.

[Bukama]

Hmm, I hadn't thought of that. We should probably move TimeoutUtil to a separate package. Let's go with org.junit.jupiter.api.timeout for now, ok?

Actually, I've just done this on main so it should suffice for you to rebase this PR.

Great, I will work later this day / tomorrow

[Bukama]

I give up. After wasting another few hours for getting those tests green which check module system files that do nowhere exists and complain about modules would not exists while the compiler says they do.

[Bukama]

Thanks @sormuras for pointing out the obvious 🤦‍♂️ When you don't see the forest because of trees...

[marcphilipp]

Di you have time to make the requested changes? If not, please let me know and I can take over.

[testlens-app]

✅ All tests passed ✅

🏷️ Commit: 9888b92
▶️ Tests: 43477 executed
⚪️ Checks: 15/15 completed

[marcphilipp]

Thanks for all the hard work! I polished the documentation a bit and pushed two commits.