-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Exclude competing @Deprecated factory methods in fallback String-to-Object converter
#5186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Extends the algorithm to exclude deprecated methods. This extension occurs after the existing logic completes. Fixes junit-team#4996
@Deprecated factory methods in fallback String-to-Object converter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
|
@jodastephen could you satisfy the DCO bot? Oh and please ignore co-pilot. I'm not sure where that came from, but it is not something from the JUnit team. 🤔 |
✅ All tests passed ✅Test Summary
🏷️ Commit: 417f9a1 Test FailuresSeparateThreadTimeoutInvocation > throws timeout exception when timeout duration is exceeded (:jupiter-tests:test in macOS)SeparateThreadTimeoutInvocation > throws timeout exception when timeout duration is exceeded (:jupiter-tests:test in macOS)Learn more about TestLens at testlens.app. |
This extends the fallback String to Object converter algorithm to exclude deprecated methods. This occurs after the existing algorithm finished. As such, any code that works today will continue to work. It is possible that this PR will make some code that fails today start to work, but that seems to be an acceptable outcome.
Release notes will need adding.
Fixes #4996
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations