Fix run asset path traversal#2
Open
zemaj wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
.runs/<id>/assetsdirectory.Description
parseRunIdinsrc/server/validation.tsto strictly validate run IDs as UUIDs and use it for all run-related routes and operations where run IDs arrive from URLs (API handlers now callparseRunId).runDirthroughparseRunIdinsrc/server/runStore.tsso invalid/decoded traversal run IDs are rejected before touching the filesystem.resolveRunAssetPathinsrc/server/assets.tsand updatereadRunAssetto reject empty, absolute,./..segments, and any path that does not resolve under the runassetsdirectory, then read only the resolved path.src/server/api.tsto validate run IDs before reading runs, streaming events, serving assets, creating handovers, and serving handover assets.src/server/assets.test.tsand extendsrc/server/validation.test.tsto cover valid reads, traversal/absolute-path rejection, and run ID validation.Testing
pnpm run typecheck, which succeeded without errors.pnpm run test, with all tests passing (new tests included); test suite reported all tests passed.pnpm run build, which completed successfully.Codex Task