Open
Conversation
These changes are made: 1. `"cljsType": "none"` added to backend only jack-in. **The lack of this is today stopping jack-in in Calva**. 1. Custom commands added for starting the system and reloading the backend code. When the user invokes this in Calva (`ctrl+alt .`) he will get a prompt with the two commands. Given how this works in VS Code, reloading the Clojure code is now this key sequence: `ctrl+alt+. 2 enter`.
Contributor
|
This seems like it's for the clojurescript settings, but is removing the clojurescript stuff.
|
Contributor
Author
|
It is only removing the old, no-longer-used-by-calva cljs settings. The active settings are still there from line 19 in the new file: 1043077#diff-f6bafef1d75590e83c79211f86e5b30bL19 (You'll need to expand the view to show the referenced line.) Not sure I follow about the other questions. But as it is now the user gets two launch options when jacking in to the created project:
If choosing the latter both CLJ and CLJS REPLs will be set up and connected, by Calva Jack-in. It is the same as in this cheesy video: https://youtu.be/a2vRDYXDAug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are made:
"cljsType": "none"added to backend only jack-in. The lack of this is today stopping jack-in in Calva.ctrl+alt .) he will get a prompt with the two commands. Given how this works in VS Code, reloading the Clojure code is now this key sequence:ctrl+alt+. 2 enter.