Skip to content

Opening the pickle file in binary mode #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pierreluctg wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Opening the pickle file in binary mode #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions devpi_rss/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ def devpiserver_on_upload(stage, project, version, link):

if pickle_file.exists():
debug("loading pickle file: %s" % pickle_file.strpath)
with open(pickle_file.strpath, "r") as f:
with open(pickle_file.strpath, "rb") as f:
rss = pickle.load(f)
else:
debug("pickle file doesn't exist yet")
Expand Down Expand Up @@ -146,7 +146,7 @@ def devpiserver_on_upload(stage, project, version, link):
debug("writing xml file: %s" % xml_file.strpath)
rss.write_xml(open(xml_file.strpath, "w"), encoding="utf-8")

with open(pickle_file.strpath, "w") as f:
with open(pickle_file.strpath, "wb") as f:
debug("writing pickle file: %s" % pickle_file.strpath)
s = StringIO()
pickle.dump(rss, s)
Expand Down