Run PhantomJS binary from PATH rather than absolute path#4
Open
tutley wants to merge 2 commits intok4s:masterfrom
Open
Run PhantomJS binary from PATH rather than absolute path#4tutley wants to merge 2 commits intok4s:masterfrom
tutley wants to merge 2 commits intok4s:masterfrom
Conversation
Owner
|
thx for your pull request,but i think about the same,so change it when you need . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I really like this package, but I don't like how it includes the PhantomJS binary. I think this is a great idea though so I want to try and use it in a website. So, I changed the phantomjsPath to simply "phantomjs" meaning it gets executed by searching the environment's PATH variable. I have phantom installed in /usr/local/bin which is a part of my path, but in other machines it might be installed somewhere else, so using the absolute path doesn't make sense. Also, you don't want to have to be responsible for maintaining the PhantomJS library in the repository, or for including a binary for every architecture.