feat: improve text visibility over background images#50
Merged
Conversation
- Add text shadows to quote text and author for better contrast
- Add variant prop to GoalInput ('minimal' for background, 'boxed' for panels)
- Redesign minimal variant with centered text and underline style
- Use minimal variant in GoalFocusView (glass theme direct background)
- Keep boxed variant as default for panel/modal contexts
kYem
force-pushed
the
feat/improve-visibility
branch
from
236bd04 to
6cb7bed
Compare
Extract variant-specific styles into INDICATOR_STYLES and LINK_BUTTON_STYLES constants. Create reusable GoalLinkButton and GoalPicker sub-components to eliminate code duplication between minimal and boxed variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
variantprop to GoalInput component ('minimal'for direct background,'boxed'for panels)Test plan