-
Notifications
You must be signed in to change notification settings - Fork 418
feat(ui): add configurable headline and subtitle via env vars #1347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
frank-bee
wants to merge
1
commit into
kagent-dev:main
Choose a base branch
from
frank-bee:feat/configurable-ui-text
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| "use client"; | ||
| import { use } from "react"; | ||
| import ChatInterface from "@/components/chat/ChatInterface"; | ||
|
|
||
| export default function ChatPageView({ params }: { params: Promise<{ name: string; namespace: string; chatId: string }> }) { | ||
| const { name, namespace, chatId } = use(params); | ||
| export default async function ChatPageView({ params }: { params: Promise<{ name: string; namespace: string; chatId: string }> }) { | ||
| const { name, namespace, chatId } = await params; | ||
| const headline = process.env.NEXT_PUBLIC_HEADLINE; | ||
|
|
||
| return <ChatInterface | ||
| selectedAgentName={name} | ||
| selectedNamespace={namespace} | ||
| sessionId={chatId} | ||
| headline={headline} | ||
| />; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| import ChatInterface from "@/components/chat/ChatInterface"; | ||
| import { use } from 'react'; | ||
|
|
||
| // This page component receives props (like params) from the Layout | ||
| export default function ChatAgentPage({ params }: { params: Promise<{ name: string, namespace: string }> }) { | ||
| const { name, namespace } = use(params); | ||
| return <ChatInterface selectedAgentName={name} selectedNamespace={namespace} />; | ||
| } | ||
| export default async function ChatAgentPage({ params }: { params: Promise<{ name: string, namespace: string }> }) { | ||
| const { name, namespace } = await params; | ||
| const headline = process.env.NEXT_PUBLIC_HEADLINE; | ||
| return <ChatInterface selectedAgentName={name} selectedNamespace={namespace} headline={headline} />; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| import AgentList from "@/components/AgentList"; | ||
|
|
||
| export default async function AgentListPage() { | ||
| return <AgentList />; | ||
| const subtitle = process.env.NEXT_PUBLIC_SUBTITLE; | ||
| return <AgentList subtitle={subtitle} />; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting
dynamic = "force-dynamic"in the root layout disables static optimization for the entire application, which may have performance implications. Consider setting this only on the specific pages that need runtime environment variable access instead of globally.For example, you could add
export const dynamic = "force-dynamic"to:ui/src/app/page.tsx(for NEXT_PUBLIC_SUBTITLE)ui/src/app/agents/[namespace]/[name]/chat/page.tsx(for NEXT_PUBLIC_HEADLINE)ui/src/app/agents/[namespace]/[name]/chat/[chatId]/page.tsx(for NEXT_PUBLIC_HEADLINE)This would allow other pages that don't use these env vars to benefit from static optimization. Note that
NEXT_PUBLIC_*env vars are typically available at build time, but if you need them to be configurable at runtime without rebuilding, the current approach or the per-page approach is correct.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentional. The env vars need to be read at container runtime (not build time) since this is deployed as a Docker image with configurable env vars.
force-dynamicis required for that.Additionally, the sibling PR #1346 (read-only mode) also reads
NEXT_PUBLIC_READ_ONLYin the root layout, soforce-dynamicneeds to be here regardless. Scoping per-page would add boilerplate for negligible gain on a K8s dashboard app.