Skip to content

feat(ui): add keyboard shortcut hint to chat input #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
opspawn wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −0
Open

feat(ui): add keyboard shortcut hint to chat input #1408

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94d781f
feat(ui): add keyboard shortcut hint to chat input
Feb 28, 2026
9166b51
fix: resolve hydration mismatch for shortcutKey detection
Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ui/src/components/chat/ChatInterface.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,13 @@ export default function ChatInterface({ selectedAgentName, selectedNamespace, se
},
});

const [shortcutKey, setShortcutKey] = useState("Ctrl");
useEffect(() => {
if (/Mac|iPhone|iPad|iPod/.test(navigator.userAgent)) {
setShortcutKey("⌘");
}
}, []);
Comment on lines +77 to +82
Copy link

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shortcut hint will render as "Ctrl" initially and then flip to "⌘" after mount on macOS, causing an avoidable extra render and a brief incorrect hint. Consider deriving the value in the useState lazy initializer (or a useMemo) so it’s correct on the first client render without needing setShortcutKey in an effect.

Suggested change
const [shortcutKey, setShortcutKey] = useState("Ctrl");
useEffect(() => {
if (/Mac|iPhone|iPad|iPod/.test(navigator.userAgent)) {
setShortcutKey("⌘");
}
}, []);
const [shortcutKey] = useState(() =>
/Mac|iPhone|iPad|iPod/.test(
typeof navigator !== "undefined" ? navigator.userAgent : ""
)
? "⌘"
: "Ctrl"
);

Copilot uses AI. Check for mistakes.
Comment on lines +77 to +82
Copy link

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description says this uses a useMemo hook for OS detection and mentions SSR fallback, but the code uses useState + useEffect (and this is a client component). Please update the PR description (or adjust the implementation) so reviewers/users aren’t misled about the approach and SSR behavior.

Copilot uses AI. Check for mistakes.

const { handleMessageEvent } = createMessageHandlers({
setMessages: setStreamingMessages,
setIsStreaming,
Expand Down Expand Up @@ -441,6 +448,7 @@ export default function ChatInterface({ selectedAgentName, selectedNamespace, se
/>

<div className="flex items-center justify-end gap-2 mt-4">
<span className="mr-auto text-xs text-muted-foreground">{shortcutKey}+Enter to send</span>
{isVoiceSupported && (
<TooltipProvider>
<Tooltip>
Expand Down
Loading