-
Notifications
You must be signed in to change notification settings - Fork 418
feat(ui): display running version in footer (fixes #629) #1409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
78899bd
efa3798
829ae10
e188fb7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -78,6 +78,16 @@ http { | |
| return 200 'OK'; | ||
| } | ||
|
|
||
| # Version endpoint | ||
| location /version { | ||
| proxy_pass http://kagent_backend/version; | ||
| proxy_http_version 1.1; | ||
| proxy_set_header Host $host; | ||
| proxy_set_header X-Real-IP $remote_addr; | ||
| proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for; | ||
| proxy_set_header X-Forwarded-Proto $scheme; | ||
| } | ||
|
Comment on lines
+82
to
+89
|
||
|
|
||
| # Backend routes | ||
| location /api/ { | ||
| proxy_pass http://kagent_backend/api/; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workaround for the known bun segfault bug only checks for directory existence (
[ ! -d /app/ui/.next/standalone ]), not whether the build output is complete or valid. A scenario wherebun run buildexits with a non-zero code (e.g. due to a TypeScript error or OOM) but a partial/app/ui/.next/standalonedirectory already exists from a previous cached build layer would silently pass, producing a Docker image built from stale artifacts.Consider also checking for a key file inside the standalone directory, such as
server.js, to more reliably distinguish a successful build from a partial/stale one:[ ! -f /app/ui/.next/standalone/server.js ].