ci: add org-wide stale issue/PR workflow#23
Conversation
Assisted-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Gloire Rubambiza <gloire@ibm.com>
huang195
left a comment
There was a problem hiding this comment.
Clean, minimal thin-caller PR for the org-wide stale workflow. All 11 CI checks passing, DCO signed, proper Assisted-By attribution.
One concern: the reusable workflow is pinned to @main rather than a SHA — upstream changes to kagenti/.github take effect without explicit opt-in from this repo. This is common for org-internal workflows and may be intentional, but worth confirming as a deliberate choice.
Areas reviewed: CI/GitHub Actions, Security
Commits: 1 commit, signed-off: yes
CI status: all passing
|
|
||
| jobs: | ||
| stale: | ||
| uses: kagenti/.github/.github/workflows/stale.yaml@main |
There was a problem hiding this comment.
suggestion: The reusable workflow is pinned to @main. This means any change to the org workflow takes effect immediately in this repo without review here. Consider pinning to a specific SHA for supply-chain safety, or confirm this is an intentional choice for org-internal workflows.
There was a problem hiding this comment.
Good call flagging this. Using @main is an intentional choice for org-internal reusable workflows in kagenti -- we want upstream improvements (label changes, timing tweaks) to propagate automatically without requiring PRs to every consuming repo. This is the same pattern used by self-assign.yml across the org.
Added an inline comment in 6f4ae67 to make this explicit.
|
|
||
| jobs: | ||
| stale: | ||
| uses: kagenti/.github/.github/workflows/stale.yaml@main |
There was a problem hiding this comment.
praise: Minimal permissions scoped to exactly what's needed (issues: write, pull-requests: write). Clean thin-caller pattern with good header comment and reference link.
Assisted-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Gloire Rubambiza <gloire@ibm.com>
huang195
left a comment
There was a problem hiding this comment.
Clean thin-caller PR for the org-wide stale workflow. Properly scoped permissions, DCO signed, Assisted-By attribution correct. The @main pinning concern from the prior review has been addressed with an inline comment in the second commit — intentional org-internal propagation pattern matching self-assign.yml across the org. All 11 CI checks passing.
Areas reviewed: CI/GitHub Actions, Security
Commits: 2 commits, all signed-off: yes
CI status: all passing
Org-internal reusable workflows use @main so upstream improvements propagate automatically. Matches self-assign.yml and stale.yaml. See kagenti/agentic-control-plane#23 for rationale. Assisted-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Gloire Rubambiza <gloire@ibm.com>
Summary
Test plan