Support move-[nNpP] when patterns is a list#74
Open
Boolean263 wants to merge 1 commit intokana:masterfrom
Open
Support move-[nNpP] when patterns is a list#74Boolean263 wants to merge 1 commit intokana:masterfrom
move-[nNpP] when patterns is a list#74Boolean263 wants to merge 1 commit intokana:masterfrom
Conversation
This patch allows `move-n` etc. to work when a textobject is defined using a list with separate start and end patterns. Without this fix, an error is generated when the keybind is pressed for moving between these objects.
Owner
|
Thank you for the patch. I'll update tests and the document, then merge this patch. |
Owner
|
I thought at first your patch looks good, but there is a problem. If a text object is defined by a list "pattern", that text object can be nested like HTML tags. Your patch doesn't correctly handle nested objects. Suppose that a text object is defined by Doing |
Author
|
Ah, drat. I should have thought of that, but I only tested it in my own use case. Sorry to waste your time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch allows
move-netc. to work when a textobject is defined using a list with separate start and end patterns. Without this fix, an error is generated when the keybind is pressed for moving between these objects.