chore(deps): update confluentinc/cp-kafka docker tag to v8.2.0#826
Merged
chore(deps): update confluentinc/cp-kafka docker tag to v8.2.0#826
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the local/dev Kafka Docker image to Confluent Platform Kafka 8.2.0, and adjusts rdkafka admin specs to be resilient to config list ordering differences introduced by the newer Kafka image.
Changes:
- Bump
confluentinc/cp-kafkaDocker tag from8.1.1to8.2.0in both compose configurations. - Update broker/topic config assertions in
admin_spec.rbto search configs by name instead of relying onconfigs.firstordering.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spec/lib/rdkafka/admin_spec.rb | Makes config assertions order-independent by locating specific config entries by name. |
| docker-compose.yml | Updates Kafka image tag to confluentinc/cp-kafka:8.2.0. |
| docker-compose-ssl.yml | Updates Kafka image tag to confluentinc/cp-kafka:8.2.0 for the SSL compose setup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| config = resources_results.first.configs.find { |c| c.name == "log.cleaner.min.compaction.lag.ms" } | ||
| expect(config).not_to be_nil | ||
| expect(config.value).to eq("0") | ||
| expect(resources_results.first.configs.map(&:synonyms)).not_to be_empty |
There was a problem hiding this comment.
These specs now avoid relying on configs.first ordering, but there is still a remaining expectation earlier in this file that asserts resources_results.first.configs.first is compression.type/producer (around lines 179-180). With Kafka upgrades changing config ordering, that earlier assertion is likely still flaky; consider updating it to locate the config by name (similar to the new find { |c| c.name == ... } pattern) for consistency and stability.
Suggested change
| expect(resources_results.first.configs.map(&:synonyms)).not_to be_empty | |
| expect(config.synonyms).not_to be_empty |
Kafka 8.2.0 added new broker configs (e.g. ssl.keystore.credentials) which changed the ordering of configs returned by DescribeConfigs. Instead of checking .first, find configs by name to make tests resilient to config ordering changes across Kafka versions.
mensfeld
force-pushed
the
renovate/confluentinc-cp-kafka-8.x
branch
from
7d6e3fe to
84dafbe
Compare
…nings Kafka 8.2.0 logs TOPIC_ALREADY_EXISTS warnings when concurrent produce or metadata requests trigger auto-creation for the same topic. Since all tests pre-create topics via the admin API, broker-side auto-creation is unnecessary and causes spurious warnings that fail verify_kafka_warnings.
Kafka 8.2.0 logs TOPIC_ALREADY_EXISTS warnings when concurrent metadata or produce requests race to auto-create the same topic. Disabling auto.create.topics on the broker eliminates these races entirely. Pre-create the hardcoded "test" topic used by producer topic_config specs in the before(:suite) hook alongside the existing example_topic.
…ets) Kafka 8.2.0 races internally when auto-creating __consumer_offsets on first consumer group join. This is a Kafka-internal race condition that cannot be prevented from the client side.
mensfeld
force-pushed
the
renovate/confluentinc-cp-kafka-8.x
branch
from
d3cf4a9 to
fac15b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
8.1.1→8.2.0Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.