perf: fix N+1 cartesian products and add server caching#199
Open
perf: fix N+1 cartesian products and add server caching#199
Conversation
- Replace `joinedload` with `selectinload` for One-to-Many collection relationships across chat, dive sites, and dives routers. This prevents SQLAlchemy from emitting massive Cartesian products (LEFT OUTER JOINs) that cause high RAM and CPU consumption during deduplication. - Implement server-side request caching using `fastapi-cache2` with an `InMemoryBackend`. - Add caching to heavily requested static lists like `/countries` and `/regions` (1-hour cache) to prevent redundant `SELECT DISTINCT` queries. - Add caching to admin `/statistics`, `/stats`, and `/settings` endpoints (5-minute cache) to shield the database from expensive aggregation queries and configuration reads. - Update `backend/conftest.py` to initialize the cache in the test environment to prevent 500 errors during test execution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
joinedloadwithselectinloadfor One-to-Many collection relationships across chat, dive sites, and dives routers. This prevents SQLAlchemy from emitting massive Cartesian products (LEFT OUTER JOINs) that cause high RAM and CPU consumption during deduplication.fastapi-cache2with anInMemoryBackend./countriesand/regions(1-hour cache) to prevent redundantSELECT DISTINCTqueries./statistics,/stats, and/settingsendpoints (5-minute cache) to shield the database from expensive aggregation queries and configuration reads.backend/conftest.pyto initialize the cache in the test environment to prevent 500 errors during test execution.