Allow setting 'url' to work with Vite development server#327
Open
benoitlahoz wants to merge 6 commits intokartikk221:masterfrom
Open
Allow setting 'url' to work with Vite development server#327benoitlahoz wants to merge 6 commits intokartikk221:masterfrom
benoitlahoz wants to merge 6 commits intokartikk221:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to #324, #249 and #22.
Vitemiddlewares used in development server for Server-Side Rendering are writing to ExpressRequest'soriginalUrl(HyperExpress Request'surl).Additionally, they call the
writeHeadmethod of the ExpressResponse, which appears to have been removed fromExpress, but may be used by Vite on thehttpmodule response directly.This PR adds setters for
originalUrlandurl, and implements thewriteHeadmethod on the ExpressResponse.A working example can be found here.