Switch USE_SHIFTER env var name; remove scary log

[MrCreosote]

• Switches USE_SHIFTER -> USE_EXTERNAL_URLS to better describe what the env var does
• Moves the url mangling logic into config, other than the separate ee2 config
• Swtiches an error() log to a log() log as it's not actually a error, it happens all the time and is normal.

Will need to be tested in situ at NERSC.

[codecov]

Codecov Report

❌ Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.84%. Comparing base (5170db0) to head (676da48).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
JobRunner/JobRunner.py	42.85%	4 Missing ⚠️
JobRunner/config.py	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
+ Coverage   80.71%   80.84%   +0.13%     
==========================================
  Files          13       13              
  Lines        1177     1180       +3     
==========================================
+ Hits          950      954       +4     
+ Misses        227      226       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull Request Overview

This PR refactors URL management for the NERSC environment by switching from the USE_SHIFTER environment variable to USE_EXTERNAL_URLS and consolidating URL replacement logic. It also changes an error log to an informational log for a common non-error condition.

• Renamed environment variable USE_SHIFTER to USE_EXTERNAL_URLS for clearer intent
• Consolidated URL replacement logic into the Config class
• Changed Docker image not found error logging from error to info level

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File	Description
scripts/jobrunner.py	Removed URL replacement logic, moved to Config class
JobRunner/config.py	Added URL constants and URL replacement logic in Config constructor
JobRunner/JobRunner.py	Updated to use consolidated config and renamed variables for clarity
JobRunner/DockerRunner.py	Changed Docker image not found logging from error to info level

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Extra space before the equals sign in class constants. Should be single space for consistency with Python style guidelines.

[MrCreosote]

Fixed

[Copilot]

Extra space before the period in the error message. Should be 'Failed to get config. Exiting.' for consistency.

Suggested change

	self.logger.error("Failed to get config . Exiting.")
	self.logger.error("Failed to get config. Exiting.")

[MrCreosote]

Fixed

[Copilot]

Pull Request Overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}