Skip to content

Dev to main#129

Merged
ialarmedalien merged 12 commits intomainfrom
develop
Apr 10, 2026
Merged

Dev to main#129
ialarmedalien merged 12 commits intomainfrom
develop

Conversation

@ialarmedalien
Copy link
Copy Markdown
Collaborator

Description of PR purpose/changes

  • Please include a summary of the change and which issue is fixed.
  • Please also include relevant motivation and context.
  • List any dependencies that are required for this change.

Testing Instructions

  • Details for how to test the PR:
  • Tests pass locally and in GitHub Actions

Dev Checklist:

  • My code follows the guidelines at https://sites.google.com/lbl.gov/trussresources/home?authuser=0
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run Ruff format to format my code
  • I have run Ruff check and fixed any errors that it uncovered
  • Any dependent changes have been merged and published in downstream modules

Updating Version and Release Notes (if applicable)

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 10, 2026

Codecov Report

❌ Patch coverage is 89.13043% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.47%. Comparing base (9d041cf) to head (8546b1b).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/cdm_data_loaders/utils/s3.py 88.96% 16 Missing ⚠️
src/cdm_data_loaders/pipelines/ncbi_rest_api.py 86.36% 3 Missing ⚠️
src/cdm_data_loaders/parsers/uniprot/idmapping.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   53.09%   56.47%   +3.38%     
==========================================
  Files          63       63              
  Lines        3008     3079      +71     
==========================================
+ Hits         1597     1739     +142     
+ Misses       1411     1340      -71     
Files with missing lines Coverage Δ
src/cdm_data_loaders/pipelines/core.py 98.27% <100.00%> (+0.49%) ⬆️
src/cdm_data_loaders/pipelines/cts_defaults.py 100.00% <100.00%> (ø)
src/cdm_data_loaders/parsers/uniprot/idmapping.py 79.54% <50.00%> (ø)
src/cdm_data_loaders/pipelines/ncbi_rest_api.py 82.57% <86.36%> (+0.43%) ⬆️
src/cdm_data_loaders/utils/s3.py 88.96% <88.96%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d041cf...8546b1b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ialarmedalien ialarmedalien merged commit a9dfa98 into main Apr 10, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant