Skip to content

Conversation

@dauglyon
Copy link
Collaborator

No description provided.

@dauglyon dauglyon requested a review from bio-boris July 17, 2025 18:55
@bio-boris bio-boris requested a review from Copilot July 17, 2025 18:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds configurable CDM (Content Delivery Manager) domain support by replacing the hardcoded CDM domain construction with a configurable environment variable. The change allows different environments to specify their own CDM domains instead of relying on a fixed pattern.

Key Changes:

  • Replaced hardcoded CDM domain construction with configurable environment variable
  • Added CDM domain configuration support to the build system
  • Updated environment configurations with specific CDM domains

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/features/cdm/CDMRedirect.tsx Updated redirect URL to use configurable CDM domain environment variable
scripts/build_deploy.ts Added CDM domain configuration parameter and environment variable setup
config.json Added CDM domain configurations for CI and production environments

Copy link
Contributor

@bio-boris bio-boris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dauglyon dauglyon merged commit 3253f5f into main Jul 17, 2025
4 checks passed
@dauglyon dauglyon deleted the add-cdm-domain-envvar branch July 17, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants