Skip to content

Comments

Add initialization.kcp.io/wait-for-ready annotation#3

Merged
kcp-ci-bot merged 2 commits intokcp-dev:mainfrom
xrstf:waiter
Feb 10, 2026
Merged

Add initialization.kcp.io/wait-for-ready annotation#3
kcp-ci-bot merged 2 commits intokcp-dev:mainfrom
xrstf:waiter

Conversation

@xrstf
Copy link
Contributor

@xrstf xrstf commented Feb 9, 2026

Summary

This PR adds a new annotation to make the agent wait before releasing the initializer: it will wait for an object to be ready. This new annotation can be placed on any manifest.

Do note that due to the way initialization of workspaces in kcp is designed, using this functionality requires you to build your own controller that uses the initializingworkspaces virtual workspace. Regular access to the cluster is not possible since it's not yet fully initialized.

What Type of PR Is This?

/kind feature

Release Notes

Add `initialization.kcp.io/wait-for-ready` annotation

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 9, 2026
xrstf added 2 commits February 9, 2026 18:49
…ait for them to become ready

On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
Copy link
Contributor Author

xrstf commented Feb 9, 2026

/retest

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 9, 2026
@xrstf xrstf changed the title WIP - add initialization.kcp.io/wait-for-ready annotation Add initialization.kcp.io/wait-for-ready annotation Feb 9, 2026
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2026
return false, err
}

if !HasCondition(current, conditionType) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hasCondition can we make private?

Copy link

@mjudeikis mjudeikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2026
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: d123cef3e6871c62c5708b1d5fd5031b015956b4

@xrstf
Copy link
Contributor Author

xrstf commented Feb 10, 2026

Yes!

/approve

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2026
@kcp-ci-bot kcp-ci-bot merged commit 273592c into kcp-dev:main Feb 10, 2026
11 checks passed
@xrstf xrstf deleted the waiter branch February 10, 2026 10:50
@xrstf xrstf mentioned this pull request Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants