Add an option to disable certificates verification#26
Open
CryptoPascal31 wants to merge 1 commit intomasterfrom
Open
Add an option to disable certificates verification#26CryptoPascal31 wants to merge 1 commit intomasterfrom
CryptoPascal31 wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a config option to disable certs verification.
I included a warning message, when the option is enabled.
This is currently the version I use on several of my nodes to workaround the "PoolFlare issue"
I think, this PR should be merged.. Even if it's not intended to be used in “production case”, it's very convenient to allow bypassing certs verification when absolutely needed.
For the record, it appears that “mocking” the certificate cache, as we do in Chainweb:
chainweb-node/src/Network/X509/SelfSigned.hs
Line 694 in 8389549
is sufficient and is the right way to disable Cert verifications ...
It's exactly implemented in the same way in the “connection” library when dealing with TLSSettingsSimple.