Allow Symfony 7.*, use psr/log:^3.0 with newer Monolog#95
Merged
Conversation
pepamartinec
force-pushed
the
pepa_PAT-221_logger
branch
from
ba99722 to
5f511b5
Compare
pepamartinec
commented
Apr 24, 2025
Comment on lines
+21
to
+22
| - phpVersion: 8.1 | ||
| symfonyVersion: 7.2.* |
Contributor
Author
There was a problem hiding this comment.
Symfony ^7.0 vyzaduje PHP >=8.2
Member
There was a problem hiding this comment.
a tak bych asi stejně dropnul 8.1, 8.2 ne?
Contributor
Author
There was a problem hiding this comment.
8.1 muze byt, ale 8.2 mame AFAIK stale na vetsine services.
Member
There was a problem hiding this comment.
nj, ale tam se zase nepoužívá php-component, ale fair enough koukám, že vlastně i 8.1 je pořád ještě LTS
pepamartinec
commented
Apr 24, 2025
Comment on lines
+5
to
+6
| - message: '#Class Keboola\\Component\\Logger extends @final class Monolog\\Logger.#' | ||
| reportUnmatched: false |
Contributor
Author
There was a problem hiding this comment.
Deje se jen na novejsich verzich Monologu a je to delany pres @final v PHPdoc, ne final keyword pred class, takze nejjednodussi prozatim ignorovat.
pepamartinec
force-pushed
the
pepa_PAT-221_logger
branch
from
38480a2 to
51ba57b
Compare
odinuv
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E_DEPRECATEDnaErrorException- v PHP 8.4 se toho objevilo celkem dosterror_reportingdo sync akci, aby se tam deprecation vubec nereportovalo, protoze by to rozbilo output sync akcepsr/log: ^3.0(co umozni instalacnimonolog/monolog: ^3.0), nektery libs (napr. GCP SDK) uz to zacinaji vyzadovatChtel jsem to udelat +/- kompatibilni, ale kdyz zpetne vidim soupis zmen, asi bych to vydal jako major verzi?