bpf: skb_adjust_room helper refactor and tunnel decap flags#11454
Closed
kernel-patches-daemon-bpf[bot] wants to merge 5 commits intobpf-next_basefrom
Closed
bpf: skb_adjust_room helper refactor and tunnel decap flags#11454kernel-patches-daemon-bpf[bot] wants to merge 5 commits intobpf-next_basefrom
kernel-patches-daemon-bpf[bot] wants to merge 5 commits intobpf-next_basefrom
Conversation
Author
|
Upstream branch: 77378da |
kernel-patches-daemon-bpf
Bot
force-pushed
the
bpf-next_base
branch
from
fa794bf to
6e67145
Compare
Author
|
Upstream branch: 77378da |
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1068659=>bpf-next
branch
from
2b17de8 to
0bc6083
Compare
kernel-patches-daemon-bpf
Bot
force-pushed
the
bpf-next_base
branch
from
6e67145 to
c0ba5e6
Compare
Author
|
Upstream branch: 888329b |
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1068659=>bpf-next
branch
from
0bc6083 to
fa473a9
Compare
kernel-patches-daemon-bpf
Bot
force-pushed
the
bpf-next_base
branch
from
c0ba5e6 to
9f8e178
Compare
Author
|
Upstream branch: 4a4fedb |
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1068659=>bpf-next
branch
from
fa473a9 to
515da4e
Compare
kernel-patches-daemon-bpf
Bot
force-pushed
the
bpf-next_base
branch
from
9f8e178 to
1857029
Compare
Author
|
Upstream branch: 350de5b |
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1068659=>bpf-next
branch
from
515da4e to
6e5e881
Compare
kernel-patches-daemon-bpf
Bot
force-pushed
the
bpf-next_base
branch
from
1857029 to
c0c253d
Compare
Author
|
Upstream branch: 4b21ea5 |
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1068659=>bpf-next
branch
from
6e5e881 to
839e11f
Compare
Author
|
Upstream branch: 4b21ea5 |
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1068659=>bpf-next
branch
from
839e11f to
67a4299
Compare
kernel-patches-daemon-bpf
Bot
force-pushed
the
bpf-next_base
branch
from
c0c253d to
bcc2ccd
Compare
Author
|
Upstream branch: 21337b5 |
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1068659=>bpf-next
branch
from
67a4299 to
f6c7360
Compare
kernel-patches-daemon-bpf
Bot
force-pushed
the
bpf-next_base
branch
from
bcc2ccd to
5da949e
Compare
Author
|
Upstream branch: 61bc846 |
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1068659=>bpf-next
branch
from
f6c7360 to
8fad007
Compare
kernel-patches-daemon-bpf
Bot
force-pushed
the
bpf-next_base
branch
from
5da949e to
b508a4d
Compare
Author
|
Upstream branch: bfec8e8 |
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1068659=>bpf-next
branch
from
8fad007 to
eb77416
Compare
kernel-patches-daemon-bpf
Bot
force-pushed
the
bpf-next_base
branch
from
b508a4d to
1aca26a
Compare
Author
|
Upstream branch: bb6da65 |
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1068659=>bpf-next
branch
from
eb77416 to
e7e9bfd
Compare
kernel-patches-daemon-bpf
Bot
force-pushed
the
bpf-next_base
branch
from
1aca26a to
5e0b02c
Compare
Author
|
Upstream branch: 833ef4a |
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1068659=>bpf-next
branch
from
e7e9bfd to
d425c2b
Compare
kernel-patches-daemon-bpf
Bot
force-pushed
the
bpf-next_base
branch
from
5e0b02c to
e2709a6
Compare
Author
|
Upstream branch: b43d574 |
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1068659=>bpf-next
branch
from
d425c2b to
cb6b9ed
Compare
kernel-patches-daemon-bpf
Bot
force-pushed
the
bpf-next_base
branch
from
e2709a6 to
d153d04
Compare
The existing anonymous enum for BPF_FUNC_skb_adjust_room flags is named to enum bpf_adj_room_flags to enable CO-RE (Compile Once - Run Everywhere) lookups in BPF programs. Co-developed-by: Max Tottenham <mtottenh@akamai.com> Signed-off-by: Max Tottenham <mtottenh@akamai.com> Co-developed-by: Anna Glasgall <aglasgal@akamai.com> Signed-off-by: Anna Glasgall <aglasgal@akamai.com> Signed-off-by: Nick Hudson <nhudson@akamai.com> Reviewed-by: Willem de Bruijn <willemb@google.com>
Add new bpf_skb_adjust_room() decapsulation flags: - BPF_F_ADJ_ROOM_DECAP_L4_GRE - BPF_F_ADJ_ROOM_DECAP_L4_UDP - BPF_F_ADJ_ROOM_DECAP_IPXIP4 - BPF_F_ADJ_ROOM_DECAP_IPXIP6 These flags let BPF programs describe which tunnel layer is being removed, so later changes can update tunnel-related GSO state accordingly during decapsulation. This patch only introduces the UAPI flag definitions and helper documentation. Co-developed-by: Max Tottenham <mtottenh@akamai.com> Signed-off-by: Max Tottenham <mtottenh@akamai.com> Co-developed-by: Anna Glasgall <aglasgal@akamai.com> Signed-off-by: Anna Glasgall <aglasgal@akamai.com> Signed-off-by: Nick Hudson <nhudson@akamai.com> Reviewed-by: Willem de Bruijn <willemb@google.com>
Introduce helper masks for bpf_skb_adjust_room() flags to simplify validation logic: - BPF_F_ADJ_ROOM_DECAP_L4_MASK - BPF_F_ADJ_ROOM_DECAP_IPXIP_MASK - BPF_F_ADJ_ROOM_ENCAP_MASK - BPF_F_ADJ_ROOM_DECAP_MASK Add flag validation to bpf_skb_net_grow() to reject invalid encap flags early. Refactor existing validation checks in bpf_skb_net_shrink() and bpf_skb_adjust_room() to use the new masks (no behavior change). Co-developed-by: Max Tottenham <mtottenh@akamai.com> Signed-off-by: Max Tottenham <mtottenh@akamai.com> Co-developed-by: Anna Glasgall <aglasgal@akamai.com> Signed-off-by: Anna Glasgall <aglasgal@akamai.com> Signed-off-by: Nick Hudson <nhudson@akamai.com> Reviewed-by: Willem de Bruijn <willemb@google.com>
Add checks to require shrink-only decap, reject conflicting decap flag combinations, and verify removed length is sufficient for claimed header decapsulation. Co-developed-by: Max Tottenham <mtottenh@akamai.com> Signed-off-by: Max Tottenham <mtottenh@akamai.com> Co-developed-by: Anna Glasgall <aglasgal@akamai.com> Signed-off-by: Anna Glasgall <aglasgal@akamai.com> Signed-off-by: Nick Hudson <nhudson@akamai.com> Reviewed-by: Willem de Bruijn <willemb@google.com>
On shrink in bpf_skb_adjust_room(), clear tunnel-specific GSO flags
according to the decapsulation flags:
- BPF_F_ADJ_ROOM_DECAP_L4_UDP clears SKB_GSO_UDP_TUNNEL{,_CSUM}
- BPF_F_ADJ_ROOM_DECAP_L4_GRE clears SKB_GSO_GRE{,_CSUM}
- BPF_F_ADJ_ROOM_DECAP_IPXIP4 clears SKB_GSO_IPXIP4
- BPF_F_ADJ_ROOM_DECAP_IPXIP6 clears SKB_GSO_IPXIP6
When all tunnel-related GSO bits are cleared, also clear
skb->encapsulation.
Co-developed-by: Max Tottenham <mtottenh@akamai.com>
Signed-off-by: Max Tottenham <mtottenh@akamai.com>
Co-developed-by: Anna Glasgall <aglasgal@akamai.com>
Signed-off-by: Anna Glasgall <aglasgal@akamai.com>
Signed-off-by: Nick Hudson <nhudson@akamai.com>
Author
|
Upstream branch: 02bcf8e |
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1068659=>bpf-next
branch
from
cb6b9ed to
89a75d7
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1068659 expired. Closing PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: skb_adjust_room helper refactor and tunnel decap flags
version: 2
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1068659