bpf: Support struct btf_struct_meta via KF_IMPLICIT_ARGS#11468
Closed
kernel-patches-daemon-bpf[bot] wants to merge 3 commits intobpf-next_basefrom
Closed
bpf: Support struct btf_struct_meta via KF_IMPLICIT_ARGS#11468kernel-patches-daemon-bpf[bot] wants to merge 3 commits intobpf-next_basefrom
kernel-patches-daemon-bpf[bot] wants to merge 3 commits intobpf-next_basefrom
Conversation
Author
|
Upstream branch: 77378da |
kernel-patches-daemon-bpf
Bot
force-pushed
the
bpf-next_base
branch
from
6e67145 to
c0ba5e6
Compare
Author
|
Upstream branch: 888329b |
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1068916=>bpf-next
branch
from
c594770 to
b1f79d2
Compare
kernel-patches-daemon-bpf
Bot
force-pushed
the
bpf-next_base
branch
from
c0ba5e6 to
9f8e178
Compare
Author
|
Upstream branch: 4a4fedb |
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1068916=>bpf-next
branch
from
b1f79d2 to
c74eb91
Compare
kernel-patches-daemon-bpf
Bot
force-pushed
the
bpf-next_base
branch
from
9f8e178 to
1857029
Compare
Author
|
Upstream branch: 350de5b |
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1068916=>bpf-next
branch
from
c74eb91 to
afd3429
Compare
kernel-patches-daemon-bpf
Bot
force-pushed
the
bpf-next_base
branch
from
1857029 to
c0c253d
Compare
Author
|
Upstream branch: 4b21ea5 |
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1068916=>bpf-next
branch
from
afd3429 to
7a2603b
Compare
Author
|
Upstream branch: 4b21ea5 |
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1068916=>bpf-next
branch
from
7a2603b to
48b5609
Compare
kernel-patches-daemon-bpf
Bot
force-pushed
the
bpf-next_base
branch
from
c0c253d to
bcc2ccd
Compare
Author
|
Upstream branch: 21337b5 |
The following kfuncs currently accept void *meta__ign argument: * bpf_obj_new_impl * bpf_obj_drop_impl * bpf_percpu_obj_new_impl * bpf_percpu_obj_drop_impl * bpf_refcount_acquire_impl * bpf_list_push_front_impl * bpf_rbtree_add_impl The __ign suffix is an indicator for the verifier to skip the argument in check_kfunc_args(). Then, in fixup_kfunc_call() the verifier may set the value of this argument to struct btf_struct_meta * kptr_struct_meta from insn_aux_data. BPF programs must pass a dummy NULL value when caling these kfuncs. Additionally, the list and rbtree _impl kfuncs also accept an implicit u64 argument, which doesn't require __ign suffix because it's a scalar, and BPF programs explicitly pass 0. Add new kfuncs with KF_IMPLICIT_ARGS [1], that correspond to each _impl kfunc accepting meta__ign. The existing _impl kfuncs remain unchanged for backwards compatibility. To support this, add "btf_struct_meta" to the list of recognized implicit argument types in resolve_btfids. Implement is_kfunc_arg_implicit() in the verifier, that determines implicit args by inspecting both (_impl and non-_impl) BTF prototypes of the kfunc. Update the special_kfunc_list in the verifier and relevant checks to support both the old _impl and the new KF_IMPLICIT_ARGS variants of btf_struct_meta users. [1] https://lore.kernel.org/bpf/20260120222638.3976562-1-ihor.solodrai@linux.dev/ Signed-off-by: Ihor Solodrai <ihor.solodrai@linux.dev>
Update selftests to use the new non-_impl kfuncs marked with KF_IMPLICIT_ARGS by removing redundant declarations and macros from bpf_experimental.h (the new kfuncs are present in the vmlinux.h) and updating relevant callsites. Fix spin_lock verifier-log matching for lock_id_kptr_preserve by accepting variable instruction numbers. The calls to kfuncs with implicit arguments do not have register moves (e.g. r5 = 0) corresponding to dummy arguments anymore, so the order of instructions has shifted. Signed-off-by: Ihor Solodrai <ihor.solodrai@linux.dev> Acked-by: Mykyta Yatsenko <yatsenko@meta.com>
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1068916=>bpf-next
branch
from
48b5609 to
5b9d707
Compare
kernel-patches-daemon-bpf
Bot
force-pushed
the
bpf-next_base
branch
from
bcc2ccd to
5da949e
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1068916 expired. Closing PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: Support struct btf_struct_meta via KF_IMPLICIT_ARGS
version: 3
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1068916