fix: modify queue gauge to use prometheus naming convention #64
Merged
nuclearcat merged 1 commit intokernelci:mainfrom Mar 18, 2026
Merged
Conversation
gustavobtflores
changed the title
AmadeusK525
approved these changes
Dec 15, 2025
Comment on lines
147
to
+151
| metrics.push_str( | ||
| "# HELP kcidb_json_files_total Total number of JSON files in the spool directory\n", | ||
| ); | ||
| metrics.push_str("# TYPE kcidb_json_files_total gauge\n"); | ||
| metrics.push_str(&format!("kcidb_json_files_total {}\n", json_files_num)); | ||
| metrics.push_str("# TYPE kcidb_json_files gauge\n"); | ||
| metrics.push_str(&format!("kcidb_json_files {}\n", json_files_num)); |
There was a problem hiding this comment.
Need to change the help string as well
gustavobtflores
force-pushed
the
fix/kcidb-queue-gauge-naming
branch
from
3edecdc to
69b142c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify kcidb_json_files_total to kcidb_json_files to follow prometheus gauge naming conventions