[cpu_runtime] Raise exception if library is not found.#129
Merged
Conversation
Currently if a kernel library is not found nexus fails silently. This changes throws an exception in cpp runtime which gets translated to python ValueError by pybind. Adding a test to verify, and updating the current test.py to catch up with library changes.
Contributor
Author
|
I am trying to figure out how to error in python binding implementation as that would work across all plugins and not just cpu. Will update this with that soon. |
sjw36
approved these changes
Mar 27, 2026
Collaborator
sjw36
left a comment
sjw36
left a comment
There was a problem hiding this comment.
Nice!
Nexus is built to not throw exceptions, just invalid objects. But python seems to prefer throwing exceptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if a kernel library is not found nexus fails silently.
This changes throws an exception in cpp runtime which gets translated to python ValueError by pybind.
Adding a test to verify, and updating the current test.py to catch up with library changes.