add an event handler for when the websocket client detects a missing pong...#30
Open
dangduc wants to merge 2 commits intokerryjiang:masterfrom
dangduc:master
Open
add an event handler for when the websocket client detects a missing pong...#30dangduc wants to merge 2 commits intokerryjiang:masterfrom dangduc:master
dangduc wants to merge 2 commits intokerryjiang:masterfrom
dangduc:master
Conversation
added 2 commits
February 24, 2015 17:34
…d by the first timeout event putting websocket into a bad state. The fix is to clean up class vars used to check the pong timeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to allow users of the websocket client to handle the case where the client detects a pong not being sent back from a websocket server.