feat(sitemap): add <lastmod> support with per-page timestamps#4480
Open
iitzIrFan wants to merge 12 commits intokestra-io:mainfrom
Open
feat(sitemap): add <lastmod> support with per-page timestamps#4480iitzIrFan wants to merge 12 commits intokestra-io:mainfrom
iitzIrFan wants to merge 12 commits intokestra-io:mainfrom
Conversation
Member
|
cc @Piyush-r-bhaskar ok for you to merge this one? |
elevatebart
requested changes
Apr 14, 2026
Contributor
elevatebart
left a comment
There was a problem hiding this comment.
Let us check first if it actually works. I believe it does not
Comment on lines
+4
to
+5
| import fs from "fs" | ||
| import path from "path" |
Contributor
There was a problem hiding this comment.
I do not think this will work on cloudflare.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #4462
Tested with custom script which can be used for testing this PR,
ref. #4462 (comment)