Skip to content

feat(autopatch): support fallback binary patterns#1074

Open
ramhaidar wants to merge 1 commit into
keylase:masterfrom
ramhaidar:feat/autopatch-fallback-patterns
Open

feat(autopatch): support fallback binary patterns#1074
ramhaidar wants to merge 1 commit into
keylase:masterfrom
ramhaidar:feat/autopatch-fallback-patterns

Conversation

@ramhaidar
Copy link
Copy Markdown
Collaborator

Purpose of proposed changes

Improve autopatch so patching can fall back to alternate binary signatures instead of failing on first mismatch. This makes patch generation more resilient across nearby binary variants and reduces manual rework when byte patterns shift between builds

Essential steps taken

  • Added support for comma-separated binary alternatives in search and replacement patterns.
  • Validate each search/replacement alternative pair before applying a patch, so fallback patterns stay length-safe.
  • Narrowed error handling to urllib.error.URLError so unexpected failures are not silently grouped with network errors.
  • Kept change scoped to win/tools/autopatch/autopatch.py.

- Allows comma-separated binary alternatives so patching can try fallback byte patterns
- Validates each search/replacement alternative pair before applying patches
- Unhandled failures now surface outside URLError handling
- Target: Windows Autopatch Tool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant