Fix: Local reviews no longer trigger git clone operations#14
Closed
pranavsriram8 wants to merge 1 commit intokhezen:mainfrom
Closed
Fix: Local reviews no longer trigger git clone operations#14pranavsriram8 wants to merge 1 commit intokhezen:mainfrom
pranavsriram8 wants to merge 1 commit intokhezen:mainfrom
Conversation
- Add ScopeIdentifierLocalSignature for local review scope detection - Thread is_local flag through ScopeIdentifier and ReviewPipeline - Skip git MCP server initialization when repo already present - Extract shared scope docstring into reusable constants (DRY) - Update README DSPy Signatures table with local variant
Owner
|
fixed in #15 changes to _create_mcp_tools are good but I prefer a more agentic approach to the DSPy signature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When running
codespy review-localorcodespy review-uncommitted, the scope identifier still attempted to clone the repository via git tools — even though the repo was already present locally. This could cause failures in detached HEAD states or environments without git remote access.Solution
Introduced an
is_localmode that skips git operations during scope identification when the repository is already on disk.