Refactor: Split monolithic config.py into focused config/ package

[Copilot]

wifite/config.py was a 1,444-line god-class mixing default values, argument parsing for 10+ feature areas, validation logic, and OUI loading. This PR extracts those responsibilities into a proper package while keeping all call-sites unchanged.

New structure

wifite/config/
├── __init__.py          # Slim Configuration class (434 lines) — thin delegating wrappers
├── defaults.py          # initialize_defaults(cls) — all default values
├── validators.py        # validate(), validate_eviltwin_config(), validate_wpasec_config(), …
├── manufacturers.py     # OUI lazy-load
└── parsers/
    ├── settings.py      # parse_settings_args, parse_encryption, parse_wep_attacks
    ├── wep.py           # parse_wep_args
    ├── wpa.py           # parse_wpa_args  (WPA2 + WPA3 + OWE)
    ├── wps.py           # parse_wps_args
    ├── pmkid.py         # parse_pmkid_args
    ├── eviltwin.py      # parse_eviltwin_args, display_eviltwin_interface_info
    ├── attack_monitor.py
    ├── dual_interface.py
    └── wpasec.py        # parse_wpasec_args + parse_tui_args

Compatibility

wifite/config.py is replaced by the package; Python prefers the package directory, so every existing import continues to work with zero call-site changes:

from wifite.config import Configuration   # unchanged
from ..config import Configuration        # unchanged

Configuration.version is still accessible at import time (required by setup.py). All public methods retain their original signatures — __init__.py methods are thin delegates that lazy-import from the relevant sub-module.

What changed

• Deleted wifite/config.py; replaced by wifite/config/__init__.py + 13 sub-modules
• Each parse_* method in Configuration now calls the corresponding standalone function in parsers/
• Validation helpers (_validate_eviltwin_config, _validate_wpasec_config, etc.) moved to validators.py; Configuration keeps the _validate_* classmethods as pass-throughs for backward compat
• Lazy imports inside validator functions are preserved (and documented) to avoid circular-import issues with InterfaceManager and Tshark
• Added tests/test_config_refactor.py — 31 tests covering imports, initialization, validation, and temp-dir helpers

Original prompt

Refactor the monolithic configuration module in kimocoder/wifite2 into a more maintainable internal structure while preserving backward compatibility and behavior.

Repository

• kimocoder/wifite2
• Base branch: master

Goal

Reduce the size and complexity of wifite/config.py by splitting responsibilities into focused modules, while keeping the public API stable for the rest of the codebase.

Requirements

1. Keep existing imports working:
   • from wifite.config import Configuration
   • from ..config import Configuration
   • from .config import Configuration
     These must continue to work without requiring broad call-site changes.
2. Preserve runtime behavior and CLI behavior.
3. Do not introduce user-facing breaking changes.
4. Prefer a minimal safe refactor over a deep redesign.

Suggested refactor shape

Create a new internal package structure under wifite/config/ and move logic out of the current monolithic file into focused modules, for example:

• wifite/config/defaults.py — default values and initialization helpers
• wifite/config/validators.py — validation helpers and configuration validation routines
• wifite/config/manufacturers.py — manufacturer/OUI loading logic
• wifite/config/parsers/ — split argument parsing logic into focused modules such as:
  • settings.py
  • wep.py
  • wpa.py
  • wps.py
  • pmkid.py
  • eviltwin.py
  • attack_monitor.py
  • dual_interface.py
  • wpasec.py

You do not have to use exactly these filenames if a better structure emerges, but the end state should clearly separate responsibilities.

Compatibility constraints

• Keep wifite/config.py as the compatibility entrypoint exposing Configuration.
• The Configuration class should remain the primary interface used by the rest of the project.
• Avoid sweeping refactors across the whole repository unless necessary.
• If useful, Configuration methods may delegate to helper modules rather than contain all logic inline.

Scope guidance

Focus on extracting and reorganizing logic rather than redesigning the entire config system.
A good outcome is:

• wifite/config.py becomes much smaller and easier to understand.
• Parsing, defaults, validation, and data-loading responsibilities are separated.
• Existing tests continue to pass, or new tests are added if needed to cover the refactor.

Validation

Please run or update relevant tests for the refactor. At minimum, ensure imports and key configuration flows still work, especially:

• initialization
• argument parsing
• validation
• temp directory helpers
• compatibility with existing callers

Notes from repo inspection

• wifite/config.py is currently a large monolithic module (~1400+ lines) with many class attributes and many parse_* methods.
• The codebase imports Configuration widely, so preserving the public interface is critical.
• setup.py imports Configuration.version, so import-time compatibility matters.

Deliverable

Open a PR implementing the minimal safe config refactor with backward compatibility preserved.

The following is the prior conversation context from the user's chat exploration (may be truncated):

User: Scan the project for issues, problems or improvements to add. Summary me the findings

Assistant:

I'll scan the repository to understand its structure, current issues, and code quality. Let me gather information from multiple angles.

Assistant: Now let me scan the codebase for potential issues, code quality problems, and improvement opportunities.

Assistant: Now let me also look at the existing TODO items and check for test coverage:

Assistant: Here's a comprehensive summary of my findings after scanning the kimocoder/wifite2 project:

---

📋 Project Scan Summary

📊 Overview

• Language: Python | License: GPLv2 | ⭐ 1,426 stars | 🍴 254 forks
• Fork of: derv82/wifite2 — actively maintained with significant new features (Evil Twin, TUI, WPA3/SAE, dual-interface, wpa-sec upload, etc.)
• Open Issues: 2 | Open PRs: 0

---

🐛 Open Issues

#	Title	Summary
#363	aircrack-ng NOT utilising "neon" SIMD on Raspberry Pi 5	On RPi5, wifite uses --simd=generic instead of neon, resulting in ~13x slower hash rates (210 k/s vs 2800 k/s). Wifite may need to detect SIMD capabilities and pass --simd=neon to aircrack-ng explicitly.
#160	WPS always "No" on WiFi Pineapple MK7	On OpenWRT-based devices, WPS always shows as "No" or "Lock". Likely a parsing/compatibility issue with older tool versions on embedded platforms.

---

🔧 Code-Level Findings

1. Acknowledged TODOs & HACKs in Code 🟡

Multiple TODO, FIXME, XXX, and HACK markers exist throughout the codebase:

• wifite/model/handshake.py — `HA...

This pull request was created from Copilot chat.

---

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

[Copilot]

Copilot wasn't able to review any files in this pull request.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.