Skip to content

Fix stale TODO comment around hidden WPA handshake --strip flag #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kimocoder merged 2 commits into from
Mar 19, 2026
Merged

Fix stale TODO comment around hidden WPA handshake --strip flag #470

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fadff2b
Initial plan
Copilot Mar 19, 2026
12d344a
fix: replace stale TODO with accurate comment around --strip flag
Copilot Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion wifite/args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,7 +811,11 @@ def _add_wpa_args(self, wpa):
% self.config.wpa_attack_timeout))
wpa.add_argument('-wpat', help=argparse.SUPPRESS, action='store', dest='wpa_attack_timeout', type=int)

# TODO: Uncomment the --strip option once it works
# Handshake stripping is implemented (see Handshake.strip()), but the public
# --strip flag remains hidden because stripped captures may break compatibility
# with aircrack-ng and other downstream tools (Handshake.strip() warns of this).
# Keep only the hidden compatibility alias (-strip) until the behavior is
# validated across all supported cracking tools.
Comment on lines +814 to +818
'''
wpa.add_argument('--strip',
action='store_true',
Expand Down
Loading