fix(lint): record skill frontmatter values for selector coverage#216
Merged
swedishborgie merged 1 commit intoMay 13, 2026
Merged
Conversation
Branch-Creation-Time: 2026-05-13T13:12:22+0000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validateSelectorCoveragechecks each user-supplied selector againstlintCollector.allFrontmatterValues, the set of key/value pairs seen acrossall discovered markdown files. That map was populated only from
makeMarkdownWalkFunc(tasks/commands/rules);loadSkillEntryrecorded theskill file but never its frontmatter values.
Result: a selector key declared only in SKILL.md frontmatter (e.g. a
pluginkey injected by an upstream plugin converter into a skill-only plugin's
SKILL.md) would falsely trigger
selector '<k>=<v>' matched no discovered files, even though the matching skill loaded and was included successfully.Fix: call
recordFrontmatterValues(frontmatter.BaseFrontMatter)alongsidethe existing
recordFilecall inloadSkillEntry, matching the order usedin
makeMarkdownWalkFunc(record before theMatchesIncludesfilter socoverage reflects every discovered file, not only matched ones).
Adds
TestLint_SelectorMatched_FromSkillFrontmattercovering the regression.No change to runtime (
Run()) behavior —MatchesIncludesalready parsesthe skill frontmatter directly; only
Lint()'s coverage check was affected.