Conversation
WalkthroughThe PR adds Mp4v (MPEG-4 video) support: a new Any::Mp4v variant, a mp4v module and public re-export, a Codec::Mp4v variant with Decode/Encode handling, and a new public Mp4v atom struct (fields: visual, esds, btrt, taic) implementing Atom::KIND, decode_body, and encode_body. A unit test verifies encode/decode roundtrip. 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kixelated
left a comment
There was a problem hiding this comment.
If you want to move esds, go for it. I don't really understand it well enough.
From ISO/IEC 14496-14:2020 Section 6.7.
1c1f503 to
666b2a2
Compare
|
I'm not sure that the existing So I'm going to park this for now. |
From ISO/IEC 14496-14:2020 Section 6.7.
@kixelated This re-uses the
esds(ESDBox) that is currently undermp4a. Thoughts on possible re-arrangement of the files / implementation?