Fix dref url self_contained flag bit position#147
Fix dref url self_contained flag bit position#147iameli wants to merge 1 commit intokixelated:mainfrom
Conversation
The self_contained flag in the url box should be bit 0 (0x000001) per ISOBMFF §8.7.2, but was defined at bit index 1, producing flags=0x000002. This could cause strict parsers to interpret the data reference as non-self-contained. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe change modifies the default behavior of the Url extension in the ISOBMFF format handling. Specifically, the 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can get early access to new features in CodeRabbit.Enable the |
|
Fix looks good. Needs a test case. |
Noticed that this library was setting 0x000002 on the
urlbox and couldn't figure out why; Claude figured out it was a bug. Neat.From Claude: