fix: use net.Dial in socat for dual-stack support (Happy Eyeballs)#3692
Open
matejvasek wants to merge 2 commits intoknative:mainfrom
Open
fix: use net.Dial in socat for dual-stack support (Happy Eyeballs)#3692matejvasek wants to merge 2 commits intoknative:mainfrom
matejvasek wants to merge 2 commits intoknative:mainfrom
Conversation
ResolveTCPAddr + DialTCP resolves the hostname to a single address and dials it directly. When DNS returns both A and AAAA records (dual-stack Docker network), the IPv4 address is typically returned first. On IPv6-only pods this fails with "network is unreachable" because the pod has no IPv4 connectivity. Switch to net.Dial which implements Happy Eyeballs (RFC 6555): it resolves all addresses, tries them concurrently with IPv6 preferred, and uses whichever connects first. The tcp4/tcp6 explicit cases are also handled correctly by net.Dial. Signed-off-by: Matej Vašek <matejvasek@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
Bot
added
the
approved
matejvasek
requested review from
gauron99 and
lkingland
and removed request for
dsimansk and
jrangelramos
knative-prow
Bot
added
the
size/S
Signed-off-by: Matej Vašek <matejvasek@gmail.com>
Contributor
Author
|
PTAL @lkingland @gauron99 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3692 +/- ##
==========================================
- Coverage 56.91% 56.90% -0.01%
==========================================
Files 181 181
Lines 20933 20928 -5
==========================================
- Hits 11913 11909 -4
+ Misses 7811 7810 -1
Partials 1209 1209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
ResolveTCPAddr + DialTCP resolves the hostname to a single address and dials it directly. When DNS returns both A and AAAA records (dual-stack Docker network), the IPv4 address is typically returned first. On IPv6-only pods this fails with "network is unreachable" because the pod has no IPv4 connectivity.
Switch to net.Dial which implements Happy Eyeballs (RFC 6555): it resolves all addresses, tries them concurrently with IPv6 preferred, and uses whichever connects first. The tcp4/tcp6 explicit cases are also handled correctly by net.Dial.
/kind bug