mcp: reject relative paths in tool handlers#3694
mcp: reject relative paths in tool handlers#3694Shrey327 wants to merge 1 commit intoknative:mainfrom
Conversation
…ed tests Signed-off-by: Shrey327 <shreyansh.pathak273@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Shrey327 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
|
Welcome @Shrey327! It looks like this is your first PR to knative/func 🎉 |
|
Hi @Shrey327. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Adds
validatePath()to the MCP server that rejects non-absolute path arguments before shelling out to the func CLI. Sincecmd.Diris never set in the executor, relative paths silently resolved against the MCP server's working directory instead of the user's project turning a wrong directory failure into a silent misbehavior. This change turns that into an actionable error, matching the guidance already documented in instructions.md.All existing tests updated to uset.TempDir()and aTestValidatePathunit test added.