Skip to content

mcp: reject relative paths in tool handlers#3694

Open
Shrey327 wants to merge 1 commit intoknative:mainfrom
Shrey327:mcp-validate-absolute-path
Open

mcp: reject relative paths in tool handlers#3694
Shrey327 wants to merge 1 commit intoknative:mainfrom
Shrey327:mcp-validate-absolute-path

Conversation

@Shrey327
Copy link
Copy Markdown

Description

Adds validatePath() to the MCP server that rejects non-absolute path arguments before shelling out to the func CLI. Since cmd.Dir is never set in the executor, relative paths silently resolved against the MCP server's working directory instead of the user's project turning a wrong directory failure into a silent misbehavior. This change turns that into an actionable error, matching the guidance already documented in instructions.md.All existing tests updated to use t.TempDir() and a TestValidatePath unit test added.

…ed tests

Signed-off-by: Shrey327 <shreyansh.pathak273@gmail.com>
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 10, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Shrey327
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot requested review from dsimansk and jrangelramos May 10, 2026 14:24
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented May 10, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: Shrey327 / name: Shrey327 (f45998b)

@knative-prow knative-prow Bot added the size/L 🤖 PR changes 100-499 lines, ignoring generated files. label May 10, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 10, 2026

Welcome @Shrey327! It looks like this is your first PR to knative/func 🎉

@knative-prow knative-prow Bot added the needs-ok-to-test 🤖 Needs an org member to approve testing label May 10, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 10, 2026

Hi @Shrey327. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test 🤖 Needs an org member to approve testing size/L 🤖 PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant