Pull in updates so we’re working on the same page#39
Merged
bashandbone merged 15 commits into003-our-aim-tofrom Oct 30, 2025
Merged
Pull in updates so we’re working on the same page#39bashandbone merged 15 commits into003-our-aim-tofrom
bashandbone merged 15 commits into003-our-aim-tofrom
Conversation
Co-authored-by: bashandbone <89049923+bashandbone@users.noreply.github.com>
- Added --import-mode=importlib to pytest config to fix namespace collision - Applied pytestmark to all test files consistently - Fixed test_selector.py and test_semantic_basic.py missing pytest import - All 182 tests now collect successfully with proper marks Co-authored-by: bashandbone <89049923+bashandbone@users.noreply.github.com>
- Moved pytestmark in test_delimiters.py to after all imports - Reduced excessive blank lines after pytestmark to single blank line - All tests still collect and run correctly Co-authored-by: bashandbone <89049923+bashandbone@users.noreply.github.com>
…arks Co-authored-by: bashandbone <89049923+bashandbone@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Adam Poulemanos <89049923+bashandbone@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Adam Poulemanos <89049923+bashandbone@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Adam Poulemanos <89049923+bashandbone@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Adam Poulemanos <89049923+bashandbone@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Adam Poulemanos <89049923+bashandbone@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Adam Poulemanos <89049923+bashandbone@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Adam Poulemanos <89049923+bashandbone@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Adam Poulemanos <89049923+bashandbone@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Adam Poulemanos <89049923+bashandbone@users.noreply.github.com>
Fix test collection namespace collision and apply consistent pytest marks
Contributor
Reviewer's GuideThis PR pulls in auto-generated coverage updates, standardizes test metadata by adding pytest markers across test suites, bumps the package version, and tweaks pytest configuration to use importlib import mode. Class diagram for updated test suite metadata and configurationclassDiagram
class pytest_configuration {
+addopts: list
+testpaths: list
+python_files: list
+import_mode: importlib
}
class Test_Suite {
+pytest_markers
}
pytest_configuration --> Test_Suite : configures
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes test markers and pytest configuration across the test suite to improve test organization and selective test execution.
- Adds
pytestmarkdeclarations with appropriate test markers to test files - Configures pytest to use
--import-mode=importlibfor better module isolation - Removes extraneous blank lines for consistency
Reviewed Changes
Copilot reviewed 27 out of 28 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
pyproject.toml |
Adds --import-mode=importlib to pytest configuration |
tests/unit/engine/chunker/test_*.py |
Adds pytestmark = [pytest.mark.unit] to unit test files |
tests/test_*.py |
Adds pytestmark = [pytest.mark.unit] to root-level unit test files |
tests/performance/test_vector_store_performance.py |
Adds pytestmark with multiple markers (async_test, performance, slow) |
tests/integration/test_*.py |
Removes extra blank lines after existing pytestmark declarations |
tests/contract/test_*.py |
Adds or updates pytestmark with appropriate markers |
tests/benchmark/chunker/test_performance.py |
Adds pytestmark with benchmark, performance, and slow markers |
src/codeweaver/_version.py |
Updates version string (automated) |
coverage.xml |
Updates coverage statistics (automated) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bashandbone
commented
Oct 29, 2025
Contributor
Author
bashandbone
left a comment
There was a problem hiding this comment.
superficial conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Regenerate coverage report, bump version, and standardize pytest configuration and markers across the test suite
Enhancements:
Build:
Tests:
Chores: