Open
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This pull request introduces a new reusable
SourceNanopubcomponent for displaying links to source nanopublications, and updates the codebase to use this component throughout the UI. It also standardizes the way nanopublication links are rendered in both the Java and HTML files, replacing inline link logic with the new component for improved maintainability and consistency.Componentization and UI consistency:
SourceNanopubcomponent (SourceNanopub.javaandSourceNanopub.html) to encapsulate the logic for displaying a link to a source nanopublication, supporting additional CSS classes for styling.<a>tags for nanopublication links with<wicket:container wicket:id="np">[np]</wicket:container>, delegating rendering to the newSourceNanopubcomponent.Java code refactoring:
BookmarkablePageLinkfor nanopublication links in multiple components and pages (ItemListElement,QueryResultList,QueryResultTable,QueryResultPlainParagraph,QueryResultNanopubSet,MaintainedResourcePage,ResourcePartPage,SpacePage) with the newSourceNanopubcomponent, ensuring a single point of maintenance for nanopublication link behavior and styling.Type and API improvements:
ViewDisplay.getNanopubId()fromStringtoIRIto better reflect the underlying data and improve type safety.Imports and minor cleanups:
These changes make the codebase more maintainable, ensure a consistent user interface for nanopublication links, and improve type safety for nanopublication identifiers.