fix: address review feedback from @UdjinM6 on #7303#5
Closed
thepastaclaw wants to merge 1 commit into
Closed
Conversation
…r info in logs - Replace IsSporkValid() with GetValidSporkSigner() returning std::optional<CKeyID> so the recovered signer key flows directly into ProcessSpork. This drops the ECDSA RecoverCompact() count per inbound spork from three to one (was: once in IsSporkValid, twice in ProcessSpork via has_value() + value()). - ProcessSpork now takes the validated CKeyID as a parameter, removing the unreachable defensive check that was added in 6a4ee52 to replace the original assert. - ProcessSpork takes a peer_log_suffix string_view so the "SPORK -- hash:..." seen/updated/new-signer/new log lines include peer info again (was lost when ProcessSpork stopped taking NodeId). - Tighten ActiveSporks() doc comment to describe what it returns rather than what it "handles". Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Author
|
Hi @knst — this PR applies the follow-up for @UdjinM6's review feedback on dashpay#7303. Could you take a look when you have a chance? |
Owner
|
dashpay#7303 already includes both Udjin's patches and merged @thepastaclaw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses 2 review comment(s) from @UdjinM6 on dashpay#7303.
Review comments addressed:
Original PR: dashpay#7303
Automated fix by thepastaclaw
🤖 This was generated by an automated review bot.
Don't want automated PRs or comments on your code? You can opt out by replying here or messaging @PastaPastaPasta on Slack — we'll make sure the bot skips your PRs/repos going forward.