Support explicitly implemented interface members and default interface properties #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly implemented interface members were not supported because they contain a dot in the
MemberInfo.Name(andISymbol.Name), which would cause compiler errors because the generated class name would contain a dot. This PR fixes this by replacing a dot with a double underscore (double to prevent ambiguity as namespace dots are already replaced with a single underscore, though I am unsure if this is strictly necessary).Default interface properties were unsupported because the
GetImplementingPropertymethod looked for a matching accessor in the derived type, while default interface members are only located in the interface type.This PR fixes the latter issue as well, by searching the declaring type of the found accessor instead of the derived type.