Allow injecting a custom renderer class#166
Open
apauly wants to merge 3 commits intokomposable:masterfrom
Open
Allow injecting a custom renderer class#166apauly wants to merge 3 commits intokomposable:masterfrom
apauly wants to merge 3 commits intokomposable:masterfrom
Conversation
…signment in custom renderer
Collaborator
|
Thanks @apauly for your contribution. We'll review it shortly. Would you mind adding documentation about this change in the README? |
Contributor
Author
|
Hi @Spone , sorry for the delayed response - I've now added a section to the README. |
Spone
approved these changes
Oct 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does not really alter the behaviour of the gem, but it allows easier implementation for custom behaviour.
componenthelper optionally accepts a custom renderer classComponentRendereritself has been refactored a bit to allow customization of property assignmentUse case:
We'd like to use
komponentin a setup where we need to customize the property assignment to enable localization (including inline editing).The changes in this PR would implement an interface for customization only - without binding to a special kind of customization.
Note: The
.rubocop.ymlchange is due to a warning by rubocop itself